Skip to content

Filter extension packs by database item language#2345

Merged
koesie10 merged 1 commit intomainfrom
koesie10/filter-extension-packs-for-language
Apr 18, 2023
Merged

Filter extension packs by database item language#2345
koesie10 merged 1 commit intomainfrom
koesie10/filter-extension-packs-for-language

Conversation

@koesie10
Copy link
Copy Markdown
Member

This will filter the extension packs shown to the user when selecting an extension pack to use in the data extension editor to only include the extension packs that are compatible with the language of the database item.

Unfortunately, this required quite some changes to the tests to ensure the extension packs are actually setup properly since it's now reading the extension pack files.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

This will filter the extension packs shown to the user when selecting an
extension pack to use in the data extension editor to only include the
extension packs that are compatible with the language of the database
item.

Unfortunately, this required quite some changes to the tests to ensure
the extension packs are actually setup properly since it's now reading
the extension pack files.
@koesie10 koesie10 requested a review from starcke April 18, 2023 11:50
@koesie10 koesie10 requested a review from a team as a code owner April 18, 2023 11:50
Copy link
Copy Markdown
Contributor

@starcke starcke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@koesie10 koesie10 merged commit b9c8983 into main Apr 18, 2023
@koesie10 koesie10 deleted the koesie10/filter-extension-packs-for-language branch April 18, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants